Skip to content

fix(test): replace flaky cache consistency assertion with independent invariants #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hooyao merged 2 commits into from
Apr 2, 2026
Merged

fix(test): replace flaky cache consistency assertion with independent invariants #42

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b31e67
fix(test): replace flaky cross-property assertion with independent in…
Apr 2, 2026
411c339
fix: address review — cast to long, drop cross-property entryCount check
Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions tests/ZipDrive.Infrastructure.Caching.Tests/GenericCacheIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2241,16 +2241,24 @@ public async Task MemoryCache_Consistency_ConcurrentOperationsWithEviction_Inter
cache.BorrowedEntryCount.Should().Be(0,
"All handles returned after concurrent operations");

// Size must be consistent with entry count
int entryCount = cache.EntryCount;
// Verify invariants that hold without an atomic snapshot across properties.
// EntryCount and CurrentSizeBytes are updated via separate Interlocked ops,
// so reading them sequentially can observe a transient mismatch. Instead,
// verify each property satisfies its own invariant independently.
long currentSize = cache.CurrentSizeBytes;
int entryCount = cache.EntryCount;

currentSize.Should().Be(entryCount * entrySize,
$"Size mismatch: CurrentSizeBytes={currentSize}, EntryCount={entryCount}, expected={entryCount * entrySize}");
currentSize.Should().BeGreaterThanOrEqualTo(0,
"CurrentSizeBytes must never go negative");

// Size should not exceed capacity
currentSize.Should().BeLessThanOrEqualTo(entrySize * cacheCapacity,
Comment thread
hooyao marked this conversation as resolved.
Outdated
"CurrentSizeBytes should not exceed capacity after evictions");

(currentSize % entrySize).Should().Be(0,
$"CurrentSizeBytes ({currentSize}) should be a multiple of entry size ({entrySize}) — no partial entry leaks");

if (entryCount == 0)
currentSize.Should().Be(0, "If no entries remain, size must be zero");
Comment thread
hooyao marked this conversation as resolved.
Outdated
}

/// <summary>
Expand Down
Loading