Skip to content

Fix format string mismatch in OnConnectionWarning logging #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix format string mismatch in OnConnectionWarning logging #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ad9104
Initial plan
Copilot Oct 27, 2025
d8844f9
Fix build error: replace Warnf with structured logging in OnConnectio…
Copilot Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/listen/proxy/renderer_interactive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,12 @@ func (r *InteractiveRenderer) OnEventError(eventID string, attempt *websocket.At
// OnConnectionWarning is called when approaching connection limits
func (r *InteractiveRenderer) OnConnectionWarning(activeRequests int32, maxConns int) {
// In interactive mode, warnings could be shown in TUI
// For now, just log it
log.WithField("prefix", "proxy.InteractiveRenderer").
Warnf("High connection load detected: %d active requests (limit: %d) --max-connections=%d to increase the limit", activeRequests, maxConns)
// Use structured logging to avoid format-string mismatches and make logs machine-readable
log.WithFields(log.Fields{
"prefix": "proxy.InteractiveRenderer",
"active_requests": activeRequests,
"max_connections": maxConns,
}).Warn("High connection load detected; consider increasing --max-connections")
}

// Cleanup gracefully stops the TUI and restores terminal
Expand Down