ci: fix WACK being skipped on the release-please PR#62
Merged
Conversation
build-msix runs via if: always() to override the release-please job being skipped
on PRs, but WACK had no condition, so that upstream skip propagated through and
skipped WACK (the job skips before the matrix expands, hence the raw
'WACK (${{ matrix.platform }})' name). Gate WACK on build-msix's result instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #61's package-build gating, WACK is skipped on the release-please PR (and shows the un-expanded
WACK (${{ matrix.platform }})name, i.e. a job-level skip before the matrix expands).Cause
build-msixnowneeds: [release-please]and runs viaif: always()to override release-please being skipped on PRs. WACKneeds: [build-msix]but had noif, so the upstream skip propagated transitively throughbuild-msixand skipped WACK.Pre-Releasewas unaffected because it already usesalways().Fix
Gate WACK on build-msix's actual result:
So WACK runs whenever the package was built (PRs, release-creating pushes, force_build) and skips cleanly when build-msix is skipped (ordinary pushes to main).
Testing
ci: stop WACK being skipped by the release-please skip propagation