Skip to content

fix: crash in readPublish when payload is 1 byte #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goyalpalak18 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: crash in readPublish when payload is 1 byte #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions servers/mqtt_pit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,8 @@ void readPublish(uint8_t* buffer, uint32_t packetEnd, uint32_t offset, enum Mqtt

char payload[512] = {0};
uint32_t payloadLen = packetEnd - offset;
uint32_t copyLen = payloadLen < sizeof(payload) - 1 ? payloadLen - 2: sizeof(payload) - 1;
memcpy(payload, &buffer[offset], payloadLen < 511 ? payloadLen : 511);
uint32_t copyLen = payloadLen < sizeof(payload) - 1 ? payloadLen : sizeof(payload) - 1;
memcpy(payload, &buffer[offset], copyLen);
payload[copyLen] = '\0';

char msg[256];
Expand Down