Skip to content

fix: wrong variable names in MQTT startup log#13

Open
haydaramru wants to merge 1 commit intohoneynet:mainfrom
haydaramru:fix/correct-variable-names
Open

fix: wrong variable names in MQTT startup log#13
haydaramru wants to merge 1 commit intohoneynet:mainfrom
haydaramru:fix/correct-variable-names

Conversation

@haydaramru
Copy link
Copy Markdown

Summary

The startMqtt() function in run.sh defines the variables epollTimeoutInterval and maxPacketsPerClient, but the echo statement incorrectly references $epollTimeout and $maxPackets. As a result, the MQTT startup log displays empty values:

Starting mqtt_pit with port=1883 maxEvents=4096 epollTimeout= pubrelInterval=10000 maxPackets= maxNoClients=4096

Fix: Update the echo statement to reference the correct variable names so the log output accurately reflects the values passed to the binary:

Starting mqtt_pit with port=1883 maxEvents=4096 epollTimeoutInterval=5000 pubrelInterval=10000 maxPacketsPerClient=50 maxNoClients=4096

@Hackpaul
Copy link
Copy Markdown

Yeah good point outs , nice job !. But I think you unfortunately bring other commits in this pr , so can you take any action to reduce confusion while reviewing by mentors .

@haydaramru haydaramru force-pushed the fix/correct-variable-names branch from fe0c927 to 4a8f001 Compare March 19, 2026 15:44
@haydaramru
Copy link
Copy Markdown
Author

Thank you for pointing out that mistake🤝

@haydaramru haydaramru force-pushed the fix/correct-variable-names branch from 4a8f001 to 45c162e Compare March 20, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants