fix: wrong variable names in MQTT startup log#13
Open
haydaramru wants to merge 1 commit intohoneynet:mainfrom
Open
fix: wrong variable names in MQTT startup log#13haydaramru wants to merge 1 commit intohoneynet:mainfrom
haydaramru wants to merge 1 commit intohoneynet:mainfrom
Conversation
|
Yeah good point outs , nice job !. But I think you unfortunately bring other commits in this pr , so can you take any action to reduce confusion while reviewing by mentors . |
fe0c927 to
4a8f001
Compare
Author
|
Thank you for pointing out that mistake🤝 |
4a8f001 to
45c162e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
startMqtt()function inrun.shdefines the variablesepollTimeoutIntervalandmaxPacketsPerClient, but theechostatement incorrectly references$epollTimeoutand$maxPackets. As a result, the MQTT startup log displays empty values:Fix: Update the
echostatement to reference the correct variable names so the log output accurately reflects the values passed to the binary: