fix: format string vulnerability in MQTT disconnectClient()#11
Open
haydaramru wants to merge 1 commit intohoneynet:mainfrom
Open
fix: format string vulnerability in MQTT disconnectClient()#11haydaramru wants to merge 1 commit intohoneynet:mainfrom
haydaramru wants to merge 1 commit intohoneynet:mainfrom
Conversation
haydaramru
force-pushed
the
fix/mqtt-format-string
branch
from
655a5f5 to
80d42d4
Compare
haydaramru
force-pushed
the
fix/mqtt-format-string
branch
from
80d42d4 to
2e91e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disconnectClient()inservers/mqtt_pit.cpassess a formated message directly at the first argument toprintf():Because
msgincludes the client’s IP address (which is attacker-controlled input), a maliciously crafted value containing format specifiers such as%s,%x, or%nmay lead to application crashes or even memory corruption. This represents CWE-134 format string vulnerability.Fix:
printf("%s", msg);This pattern is already correctly applied in other parts of the file (e.g. in lines 133, 229, 280, and 865).