fix(django): capture user name and id #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
__set_user_from_context
method insideprocess_exception
of the middleware definition.More context on the fix:
request.user
is not set yet from the other middleware. The current approach was trying to set the user session before passing on to the other middleware.process_exception
). At that point, it is more probable to have the user session available if the proper middleware have been executed (i.e.django.contrib.auth.middleware.AuthenticationMiddleware
).Fixes: #155