-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack): rely on plugin-core #1211
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b3df85f
Depend on plugin core (in progress)
BethanyBerkowitz 1c1314f
Fix integration tests
BethanyBerkowitz df0bfe8
Merge branch 'master' into BKB/webpack-plugin-core
BethanyBerkowitz ce3ac0a
Start switching uploadSourcemaps to core version
BethanyBerkowitz 9c744a2
Merge branch 'master' into BKB/webpack-plugin-core
BethanyBerkowitz 9b02b3e
Fix misnamed files
BethanyBerkowitz 24fa44a
Remove unused deps
BethanyBerkowitz 0c3f8ed
Remove unused
BethanyBerkowitz 849c056
Lint
BethanyBerkowitz e2b335e
Test multiple sourcemap upload in example project
BethanyBerkowitz dcf8af6
Set revision, assetsUrl so sourcemaps get applied
BethanyBerkowitz f1a3122
Lint
BethanyBerkowitz 4f8a33b
Add test for not sending deploy
BethanyBerkowitz 40c5c3c
Merge branch 'master' into BKB/webpack-plugin-core
BethanyBerkowitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
const Honeybadger = require('@honeybadger-io/js'); | ||
|
||
Honeybadger.configure({ | ||
apiKey: process.env.HONEYBADGER_API_KEY, | ||
revision: process.env.HONEYBADGER_REVISION, | ||
}) | ||
|
||
export default Honeybadger |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,35 @@ | ||
const path = require('path'); | ||
const path = require('path') | ||
const HoneybadgerSourceMapPlugin = require('@honeybadger-io/webpack') | ||
const { EnvironmentPlugin } = require('webpack') | ||
|
||
module.exports = { | ||
entry: './src/index.js', | ||
// Entry here would normally just be the `index.js` file, however | ||
// adding multiple entry points generates multiple output files, | ||
// allowing us to test multiple source map uploads | ||
entry: { | ||
index: './src/index.js', | ||
hb: './src/hb.js', | ||
}, | ||
mode: 'production', | ||
output: { | ||
filename: 'index.js', | ||
filename: '[name].bundle.js', | ||
path: path.resolve(__dirname, 'dist'), | ||
}, | ||
devtool: 'source-map', | ||
plugins: [new HoneybadgerSourceMapPlugin({ | ||
apiKey: process.env.HONEYBADGER_API_KEY, | ||
assetsUrl: 'https://cdn.example.com/assets', | ||
revision: 'main', | ||
deploy: true | ||
})] | ||
plugins: [ | ||
new HoneybadgerSourceMapPlugin({ | ||
apiKey: process.env.HONEYBADGER_API_KEY, | ||
// assetsUrl would normally be a url where your assets are hosted | ||
// This is just to test locally, so it's a folder path instead | ||
assetsUrl: '*/dist', | ||
revision: process.env.HONEYBADGER_REVISION, | ||
deploy: { | ||
environment: 'test', | ||
localUsername: 'hbTestUser', | ||
} | ||
}), | ||
// Be aware that if you use EnvironmentPlugin, the values of those env variables | ||
// get bundled into your code as strings. | ||
new EnvironmentPlugin(['HONEYBADGER_API_KEY', 'HONEYBADGER_REVISION']) | ||
] | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯