-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check-ins #7
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is looking good. I have some other thoughts:
I'm wondering if the command run
is too generic for what it is doing. What if the command was check-in
with an optional command separator for reporting external command results? That way they can send a check-in on its own or send the results of a command execution.
I was also wondering if we should we propagate the exit code from the run command?
Yeah, I think it makes sense to be able to report a check-in without having to run a command, and that
👍 |
I like the name |
Yup! |
@rabidpraxis do you want to approve this or do you still have questions? |
No description provided.