Don't chdir globally #49
Conversation
|
I know #43 (and I'm waiting it'll be merged and released), but it seems a bit large for quick merge. |
|
Agreed, this is a good first step |
|
Could you rebase? <3 |
|
I want to add this change on #47. What's the status of it? |
|
@tagomoris merged. |
* Calling Dir.chdir in top level of Rakefile makes us not to add any tasks which should run on project root directory.
tagomoris
force-pushed
the
fix-rakefile
branch
from
36d4c2d to
247e062
Compare
|
@zzak done. |
|
Thanks @tagomoris have you checked how it plays with the changes that will be soon introduced by #43 ? |
|
@toch I think this patch as a smaller version of Eric's patch that should be easier to swallow, and allow us to move into that direction. |
|
I pushed a commit to update Rakefile by updated setup.rb |
|
ping? |
| @@ -25,27 +24,31 @@ current_gem = MRuby::Gem.current | |||
| app_version = MRuby::Gem.current.version | |||
| APP_VERSION = (app_version.nil? || app_version.empty?) ? "unknown" : app_version | |||
|
|
|||
| desc "compile all the binaries" | |||
| desc "compile binary" | |||
There was a problem hiding this comment.
this still compiles "all" binaries, right? why change the comment
There was a problem hiding this comment.
I previously worked with Rakefile generated by mruby-cli v0.0.4.
Now I fixed and pushed it.
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
| desc "run all tests" | ||
| Rake::Task['test'].clear | ||
| task :test => ['test:bintest', 'test:mtest'] | ||
| task :test => ["test:mtest", "test:bintest"] |
There was a problem hiding this comment.
why change the order and quotations?
There was a problem hiding this comment.
Pushed commits without such unneeded changes.
| @@ -133,8 +140,7 @@ Rake.application.tasks.each do |task| | |||
| old_task = Rake.application.instance_variable_get('@tasks').delete(task.name) | |||
| desc old_task.full_comment | |||
| task old_task.name => old_task.prerequisites do | |||
| abort("Not running in docker, you should type \"docker-compose run <task>\".") \ | |||
| unless is_in_a_docker_container? | |||
| abort("Not running in docker, you should type \"docker-compose run <task>\".") unless is_in_a_docker_container? | |||
| old_task.invoke | |||
There was a problem hiding this comment.
Can you put this back on two lines?
|
|
tagomoris
force-pushed
the
fix-rakefile
branch
from
52abc45 to
3055db5
Compare
|
@zzak Thank you to notify me about it. I pushed fixed commits, and another fix for |
Calling Dir.chdir in top level of Rakefile makes us not to add any tasks which should run on project root directory.
IMO, it's better to show working directory per tasks explicitly than doing chdir it globally.