Try opening redirect link automatically on native app #434
Conversation
|
I don't agree with your statement that this change will be invisible for non app users, Safari will for instance show this message now to users:
If we want to do this, we will first have to check if the url scheme is registered. Another option could be to add a new button that will (try to) open the link in the app. |
|
@bramkragten Thanks for your feedback! About using creating a new button, before creating this commit, I made another commit in another branch with this idea and also with the code from this pr, but I don't remember why I didn't continue that way. Maybe I wanted to avoid modifying the UI. |
Diegorro98
changed the title
|
I'm coming back to this concept, because the addition of a button maybe is too traumatic. So I added a condition where the redirect link is opened automatically only if the user agent is Windows, that way we avoid the Safari issue and other potential issues with other OS. |
| @@ -56,6 +62,12 @@ const render = (showTroubleshooting: boolean) => { | |||
| return; | |||
| } | |||
|
|
|||
| if (!isMobile && navigator.userAgent.includes("Windows")) { | |||
There was a problem hiding this comment.
I do like this idea, but agree with Bram that the user should never aware of this.
Just allowing it for Windows is ok. But prefer if we could also allow it for Chromium browsers on Mac, but that can be in a subsequent PR.
I will ask a Windows users to verify the behavior and then this can be merged. Definitely better than another button.
|
Triggering CI to get a preview build |
|
URL to try it is here https://deploy-preview-434--my-home-assistant.netlify.app/redirect/supervisor_store/ |
|
This is giving an error on Firefox and so that should be filtered out. Instead of filtering by Operating System, we have to find the browsers that work. |
|
You mean this one? EDIT: Nevermind, it was because Google redirect was using an empty domain. |
|
I checked it with Jorg, and it seems like it is a edge case issue |
Currently there is no way to open redirect links at the Home Assistant app at Windows because WSA doesn't register the app web link (and even if it did, web browsers at Windows doesn't open links on apps unless they are PWAs...).
This modifications will try to open the redirect link directly on the app (except if
mobileis set to1) and is completely invisible for users that doesn't have the app installed.