Skip to content

Make weather-forecast card more responsive #24900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Cretezy
Copy link

@Cretezy Cretezy commented Apr 3, 2025

Proposed change

Fairly minor change to the weather-forecast card to improve the use of space. It adds a size controller (like width on this card) to add a short class when it's short to style.

The values tweaks are minor but improves spacing/use of space/legibility in the card. Makes it feel more at home in the design language.

Dimensions Before After Comment
12x4 Screen Shot 2025-04-03 at 01 31 26 Screen Shot 2025-04-03 at 01 31 31 Vertical padding increased to fill space
12x3 Screen Shot 2025-04-03 at 01 25 43 Screen Shot 2025-04-03 at 01 25 52 Smaller icons and state text to reduce vertical space
9x3 Screen Shot 2025-04-03 at 01 26 54 Screen Shot 2025-04-03 at 01 27 02 Same as 12x3
6x4 Screen Shot 2025-04-03 at 01 35 30 Screen Shot 2025-04-03 at 01 35 25 Smaller icon

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

show_current: true
show_forecast: true
type: weather-forecast
entity: weather.home
forecast_type: daily
forecast_slots: 5
grid_options:
  columns: 12
  rows: 4
secondary_info_attribute: wind_speed

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@Cretezy Cretezy changed the title Make weather-forecast case more responsive Make weather-forecast card more responsive Apr 3, 2025
@bramkragten bramkragten added the Needs UX Pull requests requiring a review from the Home Assistant design team label Apr 22, 2025
@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Apr 29, 2025

if I may add a comment here, please let me suggest to make the card canvas smaller, and take out the top and bottom empty space that seems to make the top cards(in your overview) so empty.

Increasing the inner vertical padding 'to fill space' doesn't solve the overall look of emptiness at all, it just moves it around.

check an extreme version of reducing card height to 80% fix it:

current card styling:

Scherm­afbeelding 2025-04-29 om 09 28 19

and reduced to 80%:

Scherm­afbeelding 2025-04-29 om 09 28 10

see how much space is saved , and yet the card feels very balanced

no need to reduce icons or text, which can be less than optimal for older eyes... please also consider that aspect

@Cretezy Cretezy force-pushed the push-novlvuqmsswu branch from 47cfdbd to f74cf05 Compare May 10, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Needs UX Pull requests requiring a review from the Home Assistant design team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants