Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localizable "Zoom in" / "Zoom out" tooltips to map view #23426

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Dec 24, 2024

Proposed change

The tooltips for the "+" / "–" buttons in the map view are missing localizable "Zoom in" / "Zoom out" labels.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The tooltips for the "+" / "–" buttons in the maps view are missing localizable "Zoom in" / "Zoom out" labels.

This commit adds those strings.
@NoRi2909
Copy link
Contributor Author

Looks like we cannot add the localizable strings to the map view as these two buttons are provided by OSM?

@bramkragten
Copy link
Member

bramkragten commented Dec 24, 2024

Looks like we cannot add the localizable strings to the map view as these two buttons are provided by OSM?

By Leaflet, you can pass them as options: https://leafletjs.com/reference.html#control-zoom-zoomintitle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: Map cards missing translation of tooltips for Zoom in / out buttons
2 participants