Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll bar removed #23200

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

scroll bar removed #23200

wants to merge 1 commit into from

Conversation

1Kunalvats9
Copy link

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1Kunalvats9

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Dec 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 7, 2024 15:43
@1Kunalvats9 1Kunalvats9 marked this pull request as ready for review December 7, 2024 15:45
@ildar170975
Copy link
Contributor

Related #23193

@wendevlin
Copy link
Contributor

@1Kunalvats9 thank you, but this is just a hack around the real problem that the element is too wide. The problem itself should be solved instead of hiding it.

@silamon
Copy link
Contributor

silamon commented Dec 11, 2024

I think the overflow:auto should be taken away instead. It's the ha-textfield in the card-config class that makes it show a scrollbar although not needed.

@silamon silamon marked this pull request as draft December 11, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants