-
Notifications
You must be signed in to change notification settings - Fork 65
Add support for alpine 3.22 and drop 3.18 #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Alpine 3.22 was release a few days ago. alpinelinux.org/posts/Alpine-3.22.0-released.html - Alpine 3.18 reached its EOL last month and is therefore dropped. alpinelinux.org/releases
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Marc Mueller <[email protected]>
Thanks @onedr0p! Looking back at the PR history, it seems we might need to split this up into two separate PRs with a release in between. E.g. |
No worries, that was my initial thought too. I'll make the changes in the morning. |
@cdce8p I've updated the PR to only include the Alpine base image changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@onedr0p Any reason you merged the upstream branch here? The CI run was already green. A new build will take 4+ hours and a lot of runners. If you're able to, could you force-push remove the merge commit? Hopefully this would restore the CI status and this PR would be good to go. |
I did just that, but it seems it doesn't restore the CI status 🙈 Anyhow, this looked good before, so I'll go ahead and merge as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Apologies, I wasn't aware of the build times 😕 I'll go ahead and open PR to bump the Python base images soon. |
I could stage the PR at least as a WIP while we wait then you can merge it when ready. |
Yeah make sense. Here we go: https://github.com/home-assistant/docker-base/releases/tag/2025.06.0. |
Thanks! Looks like it needs some attention though. Restarting the failed jobs should do the trick. I don't have the permission for it unfortunately. https://github.com/home-assistant/docker-base/actions/runs/15563220512 |
Restarted |
@frenck while you are here, according to the blog post should we be deprecating support for i386, armhf and armv7 here anytime soon? We could make use of the native GH arm64 runners if true. |
Uh oh!
There was an error while loading. Please reload this page.