Tado update and improve tests #134089
Closed
Tado update and improve tests #134089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
has-tests
integration: tado
small-pr
joostlek
requested changes
Dec 27, 2024
Comment on lines
18
to
+32
| state = hass.states.get("binary_sensor.air_conditioning_power") | ||
| assert state.state == STATE_ON | ||
| assert state.attributes == snapshot | ||
|
|
||
| state = hass.states.get("binary_sensor.air_conditioning_connectivity") | ||
| assert state.state == STATE_ON | ||
| assert state.attributes == snapshot | ||
|
|
||
| state = hass.states.get("binary_sensor.air_conditioning_overlay") | ||
| assert state.state == STATE_ON | ||
| assert state.attributes == snapshot | ||
|
|
||
| state = hass.states.get("binary_sensor.air_conditioning_window") | ||
| assert state.state == STATE_OFF | ||
| assert state.attributes == snapshot |
There was a problem hiding this comment.
Rather use snapshot_platform for this
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Will be updated in a later iteration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Updating and improving tests with snapshots and expand a few scenarios to get a better overall coverage.
The Tado Connector has been left out of scope, whereas in a next PR I would like to refactor this to a Data Update Coordinator and update the tests accordingly.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: