Add mill number platform #134044
Merged
Add mill number platform #134044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
gjohansson-ST
requested changes
Dec 26, 2024
| """Initialize the number.""" | ||
| super().__init__(coordinator) | ||
|
|
||
| self.coordinator: MillDataUpdateCoordinator = coordinator |
There was a problem hiding this comment.
Suggested change
| self.coordinator: MillDataUpdateCoordinator = coordinator |
Should already be set by CoordinatorEntity
There was a problem hiding this comment.
Yes, but then I got problems with mypy
Do you have any suggestions on how to fix that? Or should I ignore that line?
There was a problem hiding this comment.
There was a problem hiding this comment.
class MillNumber(CoordinatorEntity[MillDataUpdateCoordinator], NumberEntity):
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
|
A documentation PR needs to be created and linked in the correct place in the PR description. |
8 tasks
joostlek
requested changes
Jan 1, 2025
| self.async_write_ha_state() | ||
|
|
||
| @callback | ||
| def _update_attr(self, device): |
| def __init__( | ||
| self, | ||
| coordinator: MillDataUpdateCoordinator, | ||
| mill_device, |
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
joostlek
approved these changes
Jan 1, 2025
gjohansson-ST
approved these changes
Jan 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Mill, add function to set max heating power
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: