-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .rx.set method #957
base: main
Are you sure you want to change the base?
Add .rx.set method #957
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 10 10
Lines 5151 5153 +2
=======================================
+ Hits 4466 4468 +2
Misses 685 685 ☔ View full report in Codecov by Sentry. |
@@ -391,6 +391,13 @@ def ternary(condition, _): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Remember to document :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philippjfr is this ready?
def set(self, value): | ||
""" | ||
Sets the input of the pipeline to a new value. Equivalent | ||
to ``.rx.value = value``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to ``.rx.value = value``. | |
to `.rx.value = value`. |
Are people ok with the linguistic ambiguity between "set" as a collection of items and "set" as "assign"? I find |
FWIW I'm fine with the naming of |
I like set because its the term used in React Docs. |
Implements #956