Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intro messages #922

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Add intro messages #922

merged 7 commits into from
Jan 8, 2025

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jan 7, 2025

Provides a little more guidance on what the tabs are. Feel free to update the language as you see fit

image image

@ahuang11 ahuang11 requested a review from philippjfr January 7, 2025 19:15
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.42%. Comparing base (fa0ede5) to head (d6da7a9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/ui.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   58.47%   58.42%   -0.06%     
==========================================
  Files         109      109              
  Lines       13881    13899      +18     
==========================================
+ Hits         8117     8120       +3     
- Misses       5764     5779      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

I think this is a good idea, but just want to confirm that these are replaced when you actually load a table and start an exploration.

ahuang11 and others added 2 commits January 8, 2025 07:44
Co-authored-by: Philipp Rudiger <[email protected]>
@ahuang11
Copy link
Contributor Author

ahuang11 commented Jan 8, 2025

Ok I added hide.

show.mp4

I always get confused using rx; specifically I couldn't get visible=self._explorations.param.objects.rx.bool() working. I also tried visible=param.rx(self._explorations.param.objects).rx.bool()

@philippjfr
Copy link
Member

specifically I couldn't get visible=self._explorations.param.objects.rx.bool() working

Shouldn't it be self._explorations.param.objects.rx.bool().rx.not_(), i.e. make it visible when there are no explorations?

@ahuang11
Copy link
Contributor Author

ahuang11 commented Jan 8, 2025

Yeah, but I get this error:

  File "/Users/ahuang/repos/lumen/lumen/ai/ui.py", line 500, in _table_explorer
    visible=self._coordinator.interface.param.objects.rx.bool().rx.not_()
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'function' object has no attribute 'rx'

@philippjfr
Copy link
Member

Ah okay, it should be:

self._coordinator.interface.param['objects'].rx.bool().rx.not_()

The param accessor works like a dataframe column accessors, if the parameter name clashes with an existing method the method takes precedence.

@ahuang11
Copy link
Contributor Author

ahuang11 commented Jan 8, 2025

Okay was able to use rx.

Also added an issue
holoviz/param#1005

@ahuang11 ahuang11 requested a review from philippjfr January 8, 2025 16:50
@philippjfr philippjfr merged commit 84a628d into main Jan 8, 2025
12 checks passed
@philippjfr philippjfr deleted the add_intro branch January 8, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants