Add export selector to Report#1702
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1702 +/- ##
==========================================
+ Coverage 70.16% 70.29% +0.13%
==========================================
Files 175 175
Lines 30093 30316 +223
==========================================
+ Hits 21116 21312 +196
- Misses 8977 9004 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| def _init_views(self): | ||
| views = self.param._header.rx() | ||
| self.views = self.param._header.rx() |
There was a problem hiding this comment.
Why? Seems like this will trigger a bunch of events (needlessly).
| self._prepared = False | ||
| self.status = "idle" | ||
| self._view[:] = [] | ||
| self.views = [] |
There was a problem hiding this comment.
Don't think this is correct, it unlinks the rx.
| views = list(self._header) | ||
| for task in self: | ||
| views += task.views | ||
| self.views = views |
There was a problem hiding this comment.
Again, confused here, views should be managed entirely by the rx expression.
philippjfr
left a comment
There was a problem hiding this comment.
Quite worried about some of the changes here. A big part of making things here not be insane was to manage the views of a TaskGroup via rx expressions. This eliminated a ton of logic around ensuring that things are reset and synced appropriately. Based on what I've seen here this undoes a lot of that.
I haven't followed the exact details but I'm not sure why that logic had to change at all.




Builds upon #1701 to allow subsetting which subsections to download.
Area.mp4
The output:
In use:
dm.mp4