Skip to content
Open
41 changes: 12 additions & 29 deletions profile-submission.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"team_profiles": [
{
"github_handle": "jediDean",
"full_name": "Jesse Dean",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/364"
},
{
"github_handle": "VasishtGR",
"full_name": "Vasisht G R",
Expand Down Expand Up @@ -130,11 +135,6 @@
"full_name": "Soundarya Priyadharshini",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/608"
},
{
"github_handle": "jediDean",
"full_name": "Jesse Dean",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/364"
},
{
"github_handle": "fbuka",
"full_name": "Fatawu Bukari",
Expand Down Expand Up @@ -180,11 +180,6 @@
"full_name": "Addisu Mulat",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/112"
},
{
"github_handle": "lucky-ivanius",
"full_name": "Lucky Ivanius",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/56"
},
{
"github_handle": "matheus1lva",
"full_name": "Matheus Silva",
Expand Down Expand Up @@ -491,19 +486,17 @@
"github_trial_issue_link": "https://github.com/holdex/trial/issues/624"
},
{
"github_handle": "jaibhedia",
"full_name": "Shantanu Swami",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/679"
"github_handle": "cmdillon",
"full_name": "Curtis Matthiesen-Dillon",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/648"
},
{
"github_handle": "jaibhedia",
"full_name": "Shantanu Swami",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/680"
},
{
"github_handle": "roars2121",
"full_name": "Ruairidh Orr Ewing",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/645"
"github_trial_issue_link": [
"https://github.com/holdex/trial/issues/679",
"https://github.com/holdex/trial/issues/680"
]
},
Comment on lines 518 to 525
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Schema inconsistency: array vs string.

github_trial_issue_link is an array here but a string everywhere else. This could break consumers expecting a consistent type.

Either:

  1. Keep it as a string (pick one issue), or
  2. Update the schema definition and all consumers to handle both types

Also, this change is unrelated to the PR objective (adding cmdillon).

🤖 Prompt for AI Agents
In `@profile-submission.json` around lines 493 - 500, The profile entry uses an
array for github_trial_issue_link while the schema and other entries expect a
string; change the github_trial_issue_link value in this profile to a single
string (pick one canonical issue URL) so it matches the existing schema, or if
you intend to support arrays update the global schema and all consumers
accordingly; locate the github_trial_issue_link field in the
profile-submission.json entry for "Shantanu Swami" and convert the array to a
single string to keep types consistent with other entries.

{
"github_handle": "salahudinalyb",
Expand Down Expand Up @@ -725,11 +718,6 @@
"full_name": "McDani Saputra",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/925"
},
{
"github_handle": "agung-setiawan",
"full_name": "Agung Setiawan",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/922"
},
{
"github_handle": "VinayJogani14",
"full_name": "Vinay Jogani",
Expand Down Expand Up @@ -815,11 +803,6 @@
"full_name": "Calpa Liu",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/1032"
},
{
"github_handle": "0xcoreblock",
"full_name": "Jeremy Godfrey",
"github_trial_issue_link": "https://github.com/holdex/trial/issues/147"
},
{
"github_handle": "Mutiu001",
"full_name": "Mutiu Ajiboye",
Expand Down