test(auth): harden OIDC failure cleanup - #179
Merged
Merged
Conversation
moncher-dev
marked this pull request as ready for review
August 21, 2026 05:15
hojinzs
approved these changes
Aug 21, 2026
hojinzs
left a comment
Owner
There was a problem hiding this comment.
Project #14 watchdog review — PR #179
Approve. I reviewed the PR head 4265450400a2466e732c061cf01bf4954456f81f against main.
Scope and result
- 4 files changed, +19/-2
- OIDC failure-cleanup assertions, documentation, and changeset only
- No runtime code, dependency, auth configuration, or secret changes
- No blocking correctness, security, or regression findings
- The added assertions are load-bearing: the cookie lookup helper throws when
eb_oidc_txis absent
Verification
npm run lint— passnpm test— pass (shared 53, API 204, web 29, CLI 51 tests)npm run build— passnpm -w @evidence-browser/api run test -- src/routes/auth-oidc.test.ts— passgit diff --check— pass
Browser/Dex E2E was not rerun locally because the required environment was unavailable; CI checks are successful. Non-blocking follow-ups are recorded in the evidence bundle.
Evidence: https://evidence-browser.dev0.daniworks.kr/w/evidence-browser/b/project14-pr-179-20260821-060405z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues — Closed #164
TL;DR
eb_oidc_txis cleared on failedstate,nonce, and expired transaction paths.#164.@evidence-browser/apibecause this PR touchespackages/**.변경 지점 다이어그램
packages/api/src/routes/auth-oidc.test.ts→ verifies callback failure cleanup for the signed OIDC transaction cookie.README.md→ records issue#164Authentik sign-off context and local-login-off regression coverage.docs/ACCEPTANCE_CRITERIA.md→ ties AC-04 verification to issue#164and the failure cleanup tests..changeset/oidc-failure-cleanup.md→ patch release note for OIDC verification hardening.여기부터 보세요
packages/api/src/routes/auth-oidc.test.tsfor the concrete security regression assertions.README.mdAuthentik OIDC setup section for operator-facing sign-off notes.위험 & 롤백
변경 파일
.changeset/oidc-failure-cleanup.mdpackages/api/src/routes/auth-oidc.test.tsREADME.mddocs/ACCEPTANCE_CRITERIA.mdEvidence
npm -w @evidence-browser/api run test -- src/routes/auth-oidc.test.ts— passnpm run lint— passnpm test— passnpm run build— passnpm -w @evidence-browser/web run e2e -- e2e/login-auth-config.spec.ts— passnpm -w @evidence-browser/web run e2e:oidc— pass머지 후/사람 확인
OIDC_REDIRECT_URI.AUTH_SECRETand OIDC client credentials securely.