Ticket_17 : Renamed "Appearance" section of the settings page to "Gen…

…eral"
hojat72elect · Feb 16, 2023 · 36b0a70 · 36b0a70
1 parent 609998a
commit 36b0a70
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...src/main/java/ca/on/hojat/gamenews/feature_settings/presentation/SettingsUiModelMapper.kt b/...src/main/java/ca/on/hojat/gamenews/feature_settings/presentation/SettingsUiModelMapper.kt
@@ -20,18 +20,18 @@ internal class SettingsUiModelMapperImpl @Inject constructor(
 
     override fun mapToUiModels(settings: Settings): List<SettingsSectionUiModel> {
         return listOf(
-            createAppearanceSection(settings),
+            createGeneralSection(settings),
             createAboutSection(),
         )
     }
 
     /**
-     * The "Appearance" section of the settings page.
+     * The "General" section of the settings page.
      */
-    private fun createAppearanceSection(settings: Settings): SettingsSectionUiModel {
+    private fun createGeneralSection(settings: Settings): SettingsSectionUiModel {
         return SettingsSectionUiModel(
-            id = SettingSection.APPEARANCE.id,
-            title = stringProvider.getString(R.string.settings_section_appearance_title),
+            id = SettingSection.GENERAL.id,
+            title = stringProvider.getString(R.string.settings_section_general_title),
             items = listOf(
                 SettingsSectionItemUiModel(
                     id = SettingItem.THEME.id,

diff --git a/app/src/main/java/ca/on/hojat/gamenews/feature_settings/presentation/SettingsUiState.kt b/app/src/main/java/ca/on/hojat/gamenews/feature_settings/presentation/SettingsUiState.kt
@@ -55,7 +55,7 @@ internal data class SettingsSectionItemUiModel(
 )
 
 internal enum class SettingSection(val id: Int) {
-    APPEARANCE(id = 1),
+    GENERAL(id = 1),
     ABOUT(id = 2),
 }
 

diff --git a/app/src/main/res/values-fa/strings.xml b/app/src/main/res/values-fa/strings.xml
@@ -45,7 +45,7 @@
 
     <!--    feature settings -->
     <string name="settings_toolbar_title">تنظیمات</string>
-    <string name="settings_section_appearance_title">تنظیمات ظاهری</string>
+    <string name="settings_section_general_title">تنظیمات کلی</string>
     <string name="settings_item_theme_title">تم</string>
     <string name="settings_item_theme_option_light">روشن</string>
     <string name="settings_item_theme_option_dark">تاریک</string>

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -48,7 +48,7 @@
 
     <!--    feature settings -->
     <string name="settings_toolbar_title">Settings</string>
-    <string name="settings_section_appearance_title">Appearance</string>
+    <string name="settings_section_general_title">General</string>
     <string name="settings_item_theme_title">Theme</string>
     <string name="settings_item_theme_option_light">Light</string>
     <string name="settings_item_theme_option_dark">Dark</string>