Remove outdated Crypto logic and improve ETL configuration #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added performance benchmarking tests for encryption (AES). - Modularized encryption logic with togglable `encryption.enabled`. - Refactored CSVLoader for Spring Boot compatibility. - Added configuration options via `application.properties`. - Improved logging and error handling across components.
This commit adds the Jakarta Annotation API dependency (version 2.1.1) to `common/pom.xml`. This ensures support for annotations provided by the Jakarta EE ecosystem.
- Switch to single-stage build using openjdk:11-jre-slim. - Remove multi-stage Maven build and related dependencies. - Add required JARs and scripts directly. - Simplify ENTRYPOINT for cleaner execution.
- Upgrade Docker base image to OpenJDK 21 and adjust labels. - Remove `UpdateClinicalVariableCounts` dependency from Dockerfile. - Update CSVLoader to reference `allConcepts.csv` instead of `FHS_allConcepts.csv`.
Change default hpdsDirectory from "./" to "/opt/local/hpds/". Provides a more robust default configuration for the application. Still allows overriding via application.properties if needed.
- Updated cache size from 16 to 2048 in LoadingStore. - Refactored CSVLoader to use ApplicationRunner and @value properties. - Replaced NO_ROLLUP flag with configurable rollupEnabled property. - Simplified and optimized ETL loading and processing logic. - Adjusted buffer size for CSV parsing to improve performance. - Updated application properties to streamline configuration setup.
Changed the `etl.hpds.directory` property to use the absolute path `/opt/local/hpds` instead of `./` to avoid relative path issues.
Add a trailing slash to `etl.hpds.directory` for consistency.
AbstractProcessor - Eliminated Crypto key checks in `query` and `querySync` endpoints. - Switched hpdsDataDirectory to use Field injection instead of Method Parameter injection. PicSureService.java - Simplified logic by directly processing queries without key validation. Configurations - Added application-local-dev.properties for local configurations. - Refactored `AbstractProcessor` to remove unused Crypto-related code.
Replace `CSVLoader` with `CSVLoaderNewSearch` in test setup.
The dumpStats() method call was removed to clean up the code. It was not serving any functional purpose in the current context.
Split CSVLoaderService into its own file for better modularity and maintainability. Removed the duplicate implementation from CSVLoaderNewSearch.
TDeSain
force-pushed
the
encryption-optional
branch
from
5cf238a to
805d2e0
Compare
Cleaned up unused imports in CSVLoaderService and CSVLoaderNewSearch to improve code readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several significant changes to improve the application's maintainability, performance, and configurations:
Crypto Removal:
queryandquerySyncendpoints.PicSureService.javato process queries without key validation.AbstractProcessorand configurations by eliminating unused Crypto-related code.ETL Enhancements:
CSVLoaderto utilize Spring Boot features likeApplicationRunner.rollupEnabled,hpdsDirectory) for better maintainability.hpdsDirectoryto an absolute path (/opt/local/hpds/).Dockerfile Update:
General Improvements:
Checklist