-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ingredients .json files with happycow data #40
base: master
Are you sure you want to change the base?
Conversation
@annalisetarhan thanks for the PR. Could you please check the CI? https://travis-ci.org/github/hmontazeri/is-vegan/jobs/699300029 Seems like the JSON files have syntax errors. Somewhere in nonvegan.json. |
@annalisetarhan unfortunately it's still failing. https://travis-ci.org/github/hmontazeri/is-vegan/jobs/700027479#L260 |
Fingers crossed :) |
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 31 31
Branches 7 7
=========================================
Hits 31 31 Continue to review full report at Codecov.
|
@annalisetarhan looks good. Going to merge it the coming days. Thanks for your effort! |
Hi, Just thought of this when creating #41 |
@lucasrodes That’s a very good question. I guess the easiest way would be having a maintainer for each language? |
@hmontazeri I agree with that. I'll give it a thought or two! |
Any updates on this? @hmontazeri |
Most of the changes were moving ingredients from notvegan to canbevegan according to HappyCow's list. Just a few were moving from canbevegan to notvegan, mostly tallow products (none of the sources listed in the readme support a vegan version of tallow, and I couldn't find anything else that did). Other changes were cleanup and adding ingredient variations. Also added HappyCow as a source in the readme. Justifications for changes in the google doc: https://docs.google.com/spreadsheets/d/1puByX37M3Dbu2dJvsoCVFI1TjbBtx0ZvF-PrzYuARIY/edit?usp=sharing