Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 960 allow accordions #381

Merged
merged 2 commits into from
May 13, 2024
Merged

Issue 960 allow accordions #381

merged 2 commits into from
May 13, 2024

Conversation

chandans1316
Copy link
Collaborator

@chandans1316 chandans1316 commented Apr 29, 2024

Issue

Fixes: https://merative.atlassian.net/browse/MERATIVE-960

Description

If the "Accordion" block is used in a blog post, the frontend breaks and all styling is lost. This has been updated to resolve the styling issues.

Test URLs

Copy link

aem-code-sync bot commented Apr 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 29, 2024

Page Scores Audits Google
/drafts/Keith/caregiver-burden-patient-productivity-copy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@joehanchoi joehanchoi assigned joehanchoi and unassigned joehanchoi Apr 29, 2024
@joehanchoi joehanchoi self-requested a review April 29, 2024 18:53
Copy link
Collaborator

@joehanchoi joehanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling no longer impacted by accordion block

@joehanchoi joehanchoi requested a review from keith-kaplan May 2, 2024 17:20
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Going to merge to main.

@keith-kaplan keith-kaplan merged commit 4cd4a5c into main May 13, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the issue-960-allow-accordions branch May 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants