Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LYNX-722: Style navigation menu in boilerplate #307

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

LYNX-722: Style navigation menu in boilerplate #307

wants to merge 34 commits into from

Conversation

svera
Copy link
Collaborator

@svera svera commented Feb 7, 2025 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Feb 7, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Feb 7, 2025 •
edited
Loading

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@svera svera changed the title Lynx 722 LYNX-722: Style the desktop navigation menu in boilerplate matching the mockups Feb 7, 2025
@sirugh
Copy link
Collaborator

sirugh commented Feb 7, 2025

@svera please resolve lint issues. If you cannot access the build failure log, let me know.

@svera svera changed the title LYNX-722: Style the desktop navigation menu in boilerplate matching the mockups LYNX-722: Style desktop navigation menu un boilerplate Feb 10, 2025
@svera svera changed the title LYNX-722: Style desktop navigation menu un boilerplate LYNX-722: Style desktop navigation menu in boilerplate Feb 10, 2025
loginesta
loginesta requested changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@loginesta loginesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @svera
Please see some comments below!

blocks/header/header.css Outdated Show resolved Hide resolved
blocks/header/header.css Outdated Show resolved Hide resolved
blocks/header/header.css Outdated Show resolved Hide resolved
blocks/header/header.css Outdated Show resolved Hide resolved
loginesta
loginesta approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@loginesta loginesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After pushing latest CSS changes I think we can deliver this PR

@loginesta loginesta changed the title LYNX-722: Style desktop navigation menu in boilerplate LYNX-722: Style navigation menu in boilerplate Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loginesta loginesta loginesta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svera @sirugh @loginesta