Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultimate conditional syntax #150

Merged
merged 108 commits into from
Nov 29, 2022
Merged

Ultimate conditional syntax #150

merged 108 commits into from
Nov 29, 2022

Conversation

chengluyu
Copy link
Member

No description provided.

LPTK and others added 30 commits October 5, 2022 11:34
@LPTK
Add variable symbols inserted by Typer
0601333
@chengluyu
Wire the desugaring logic with the typer
0dd6518
@chengluyu
Make some tests work
899dcf8
@chengluyu
Refactor DiffTests so code generation is after type checking
1d435fa 
There is some annoying blank lines. I don't know why.
@LPTK
Add some currently failing tests
4c11d87
@chengluyu
Implement code generation for the new syntax
ed1efa5
@chengluyu
Revert removing a DiffTests regression
868af30
@chengluyu
Report error if field els is missing in If
d06585f
@chengluyu
Pretty-print debug outputs
cbc8688
@chengluyu
Fix some test cases
5c2a8b2 
TBH, my tree construction logic is quite weird.
@chengluyu
Show the wrong syntax tree by :p
42e8b13
@chengluyu
Migrate test cases from the old branch
a3ced76
@chengluyu
Wrap some test cases in functions
8292da5
@chengluyu
Handle more UCS cases
787e69d 
- Make use of partial terms in `desugarIfBody`.
- Make use of partial patterns in `desugarMatchBranch`.
- Handle more `IfBody`s. So, it's more than SUCS.
- "And"-separation goes deeper.
- Extract minor desugaring routines.
- Some other minor changes...
@chengluyu
Rectify a false positive
7fa00ff
@chengluyu
Handle wildcard cases and dedup let bindings
841fd22
@chengluyu
Fix cases in DirectLines.mls
39ee376
@chengluyu
Review test cases in Humiliation.mls
967a2d3
@chengluyu
Implement basic exhaustiveness check
5e3fce0
@chengluyu
Suppor tuple pattern syntax and improve defualt case propagation
3fe4565
@chengluyu
Handle IfOpsApp at the pattern position
a8b1052
@chengluyu
Review test cases
c304723
@chengluyu
Fix my stupid double negation phrasing
0e9a09e
@chengluyu
Check the test case mentioned in Telegram chat
e0d976f
@chengluyu
Add missing test file changes
dfa5cec
@chengluyu
Embed UCS related code to a layer in the cake pattern
f0b2e18
@chengluyu
Get rid of Typer#Ctx
77aad6b
@chengluyu
Adjust methods due to the previous refactor
e7a1fc6
@chengluyu
Reduce boilerplate by implementing an ADT for PartialTerm
b283378
@chengluyu
Organize branches in desugarIf
ada0e7a
chengluyu and others added 18 commits November 25, 2022 01:50
@chengluyu
Change the key of FieldAliasMap to SimpleTerm
075ac1d 
Also, delete implicit parameters `matchRootLoc` since it's
included in the scrutinee.
@chengluyu
Check if name exists in freshName
fd48cbb
@chengluyu
Add a failed case about split scrutinees
2459338
@chengluyu
Fix the bug shown by the previous commit
50c1d8b
@LPTK
Add a couple of new tests
7d6384d
@LPTK
Fix parser precedences and generalize Term desugaring scheme
91a7f8c
@chengluyu
It seems that blank lines are created by a solved bug
ec8e7cc
@chengluyu
Check out mlscript/*.mls from the main branch
2a7713c
@chengluyu
Append more test files
cb9c234
@chengluyu
Revert "Append more test files"
47a3769 
This reverts commit cb9c234.
@chengluyu
Revert "Check out mlscript/*.mls from the main branch"
f72054e 
This reverts commit 2a7713c.
@chengluyu
Revert "It seems that blank lines are created by a solved bug"
def757c 
This reverts commit ec8e7cc.
@chengluyu
Checkout files at basics, codegen and gen from the fork origin
35fee65 
These files are not changed in this PR surely.
@chengluyu
Checkout files at mlscript and typegen from the fork origin
02cede5
@chengluyu
Remove blank lines from files at nu
b4c195c
@chengluyu
Prevent too much changes in PR hkust-taco#150
a06cb37
@chengluyu
Keep the original order between types, diagnosis and results
984cfe2
@chengluyu
Clean up DiffTests
407fcad
@LPTK
Copy link
Contributor

LPTK commented Nov 28, 2022

Please make one last proofreading of your diff and then request the review again.

@chengluyu chengluyu requested a review from LPTK November 29, 2022 04:41
LPTK
LPTK approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it finally LGTM! 🥳

@LPTK
Copy link
Contributor

LPTK commented Nov 29, 2022

This time I'll create a merge commit because there's a lot of history in this branch.

@LPTK LPTK merged commit 53a008a into hkust-taco:mlscript Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPTK LPTK LPTK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chengluyu @LPTK