Skip to content

temporary solution to overwriting of dftd d3 during recovery and other slurm compatibilities#61

Merged
husainadamji merged 1 commit into
mainfrom
minor_bug_fixes
Aug 12, 2025
Merged

temporary solution to overwriting of dftd d3 during recovery and other slurm compatibilities#61
husainadamji merged 1 commit into
mainfrom
minor_bug_fixes

Conversation

@husainadamji

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 10.64%. Comparing base (d7d8e56) to head (e222099).

Files with missing lines Patch % Lines
jobmanager/io/io.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   10.63%   10.64%           
=======================================
  Files          15       15           
  Lines        3995     3994    -1     
=======================================
  Hits          425      425           
+ Misses       3570     3569    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aarongarrison aarongarrison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, hopefully this will prevent turning off dispersion from resubmitted jobs when it is not specified in the configure file. I think the custom line section may need to be revisited in the future, but looks good for now.

@husainadamji
husainadamji merged commit 2fdc583 into main Aug 12, 2025
5 checks passed
@husainadamji
husainadamji deleted the minor_bug_fixes branch August 12, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants