Skip to content

Improve updateTradesHistory performance #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
primersion wants to merge 3 commits into
base: qa
Choose a base branch
from
Open

Improve updateTradesHistory performance #84

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
316a113
add index to market_tradesHistory timestamp column
primersion Jan 5, 2025
1157df1
improve updateTradesHistory performance
primersion Jan 5, 2025
413e571
use symbol instead of trade.symbol
primersion Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion contracts/market.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,13 @@ const updateTradesHistory = async (type, buyer, seller, symbol, quantity, price,
let nbTradesToDelete = tradesToDelete.length;

while (nbTradesToDelete > 0) {
let volumeToDelete = api.BigNumber(0);
for (let index = 0; index < nbTradesToDelete; index += 1) {
const trade = tradesToDelete[index];
await updateVolumeMetric(trade.symbol, trade.volume, false);
volumeToDelete = volumeToDelete.plus(trade.volume);
await api.db.remove('tradesHistory', trade);
}
await updateVolumeMetric(symbol, volumeToDelete, false);
tradesToDelete = await api.db.find(
'tradesHistory',
{
Expand Down Expand Up @@ -340,6 +342,7 @@ actions.createSSC = async () => {
await removeBadOrders();
await removeBlacklistedOrders('buy', 'waitingforlove');
await removeBlacklistedOrders('sell', 'waitingforlove');
await api.db.addIndexes('tradesHistory', [{ name: 'timestamp', index: { timestamp: 1 } }]);
Copy link
Contributor

@bt-cryptomancer bt-cryptomancer Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you gate this new index addition behind a params.updateIndex check in the same way as the mining contract?

}
};

Expand Down