Skip to content

fix: Add timeout to plugin stop requests, correctly propagate termination signals during graceful shutdown #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheCrazyGM wants to merge 2 commits into
base: qa
Choose a base branch
from
Open

fix: Add timeout to plugin stop requests, correctly propagate termination signals during graceful shutdown #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a87abce
fix: Add timeout to plugin stop requests, correctly propagate termina…
TheCrazyGM Dec 7, 2025
9355620
fix: Increase plugin stop request timeout from 2s to 6s.
TheCrazyGM Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,16 @@ const unloadPlugin = async (plugin) => {
const plg = getPlugin(plugin);
if (plg) {
logger.info(`unloading plugin ${plugin.PLUGIN_NAME}`);
res = await send(plg, { action: 'stop' });
// res = await send(plg, { action: 'stop' });
// Add timeout to prevent hanging if plugin doesn't respond
const timeout = new Promise((resolve) => setTimeout(() => {
logger.error(`[${plugin.PLUGIN_NAME}] stop request timed out`);
resolve(null);
}, 6000));

const sendPromise = send(plg, { action: 'stop' });
res = await Promise.race([sendPromise, timeout]);

plg.cp.kill('SIGINT');
}
return res;
Expand Down Expand Up @@ -162,8 +171,18 @@ const saveConfig = (lastBlockParsed) => {
const stopApp = async (signal = 0) => {
const lastBlockParsed = await stop();
saveConfig(lastBlockParsed);
// calling process.exit() won't inform parent process of signal
process.kill(process.pid, signal);

if (signal && signal !== 0) {
// We received a signal (SIGINT/SIGTERM).
// To let the parent know we died of this signal, we need to remove our listeners
// and re-send the signal to ourselves. This triggers the default handler (termination).
process.removeAllListeners('SIGINT');
process.removeAllListeners('SIGTERM');
process.kill(process.pid, signal);
} else {
// Normal exit or no specific signal passed
process.exit(0);
}
};

// graceful app closing
Expand Down