refactor TCP Server to close open connections, refactor TCP Client to handle multiple messages and close event #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jssuttles
commented
Mar 21, 2025
| }); | ||
| callback(); | ||
| }); | ||
| self.client.on('close', function() { |
Author
There was a problem hiding this comment.
On server side close, it would not clean up
jssuttles
commented
Mar 21, 2025
| if (!self.keepalive) { | ||
| self.close(); | ||
| } | ||
| self.callback(null, ack); |
Author
There was a problem hiding this comment.
wouldn't allow another message to be queued up right after the first one completed
jssuttles
commented
Mar 21, 2025
| self.callback = callback || self.callback; | ||
| if (self.awaitingResponse) { | ||
| self.callback(new Error("Can't send while awaiting response")); | ||
| callback(new Error("Can't send while awaiting response")); |
Author
There was a problem hiding this comment.
replaced the callback, so that the first message callback didn't receive the ack, but the second one did
jssuttles
commented
Mar 21, 2025
| this.handler = handler; | ||
| this.server = null; | ||
| this.socket = null; | ||
| this.sockets = []; |
jssuttles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.