WIP: Compute image ipix and only update masked indices in all sky image#144
Open
adl1995 wants to merge 1 commit intohipspy:masterfrom
Open
WIP: Compute image ipix and only update masked indices in all sky image#144adl1995 wants to merge 1 commit intohipspy:masterfrom
adl1995 wants to merge 1 commit intohipspy:masterfrom
Conversation
Contributor
|
@adl1995 - Thanks for attempting to improve this! To avoid issues at the edges, you have to call a function in scipy.ndimage or scikit-image to compute the pixel values at "target" coordinates that has an option or even by default extrapolates, i.e. if the target coordinate is just slightly outside the tile image, it will fill the tile edge pixel value and not black or white. And to be efficient, you have to first compute the target coordinate array, only for the pixels for which a given tile should be used, and only then call the "reproject" or "interpolate" function to compute the pixel values for exactly those target positions. Hope it's clear ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #79. Previously, the output image contained bright lines as the values were being summed twice at tile edges. The current change applies the resulting tile image only at certain indices, which it receives by applying a mask on the all sky image based on the ipix values.
Previous output:

Current output:

However, the updated output image now contains 'holes' where pixels values are not inserted. I believe this is an issue with the warping function we're currently using. I will trying using either
skimage.transform.warp_coordsorscipy.ndimage.map_coordiantesand see if it resolves the issue.