-
Notifications
You must be signed in to change notification settings - Fork 87
TransformerLens v3 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shayansadeghieh
wants to merge
23
commits into
hijohnnylin:main
Choose a base branch
from
shayansadeghieh:tlens-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
TransformerLens v3 #153
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8c46f54
Override compatibility issues for tlens/saelens
shayansadeghieh b4d2050
Use tlens 3.0 in ci/cd temporarily
shayansadeghieh 2863c17
Merge remote-tracking branch 'upstream/main' into tlens-v3
shayansadeghieh 3308616
Skip type checks for now in ci/cd
shayansadeghieh feda555
Update poetry lock
shayansadeghieh 6cddecd
Use saelens fork
shayansadeghieh 53bb5cf
specify commit hash for saelens
shayansadeghieh 04c5c7b
Working tests
shayansadeghieh 0afa1c3
Skip typechecking for now
shayansadeghieh 4041368
Initialization working
shayansadeghieh b417631
made it pass gpt2 forward pass for single endpoint
shayansadeghieh f1ea0ce
Set develop mode to false for tlens + saelens
shayansadeghieh 86b0264
Passing test again using compatibility mode
shayansadeghieh cd715d5
Both single integration tests passing
shayansadeghieh e1c5966
remove linting too for now
shayansadeghieh 15198c8
topk_by_token passing
shayansadeghieh 1542712
Steering integration tests failing
shayansadeghieh c9e8e9f
Revert device to cpu for CI
shayansadeghieh ddf8593
Utilize generate_stream not v2
shayansadeghieh 1db1671
Update topk_by_token with correct batch logic
shayansadeghieh b02377c
Remove more references to hookedtransformer
shayansadeghieh 52ddda0
Remove manual hook creation
shayansadeghieh a617514
temp for debugging kv cache
shayansadeghieh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hijohnnylin I don't think we need this anymore with tlens >= 3, please correct me if I'm wrong. It is causing infinite loops with model_bridge.
Try running this in a notebook and you'll see the new version of tlens automatically has mlp_block.hook_in attribute so we shouldn't need to add it: