fix(metadata): use original casing for model IDs in page titles#117
Draft
emharsha1812 wants to merge 3 commits intohijohnnylin:mainfrom
Draft
fix(metadata): use original casing for model IDs in page titles#117emharsha1812 wants to merge 3 commits intohijohnnylin:mainfrom
emharsha1812 wants to merge 3 commits intohijohnnylin:mainfrom
Conversation
Owner
|
thanks! some notes-
|
Owner
|
addendum to 2) - thsi should also be the case in the API |
Owner
|
Moving this to draft until author has time to resolve comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #83, which addresses model IDs being incorrectly uppercased.
In apps/webapp/app/[modelId]/page.tsx, the generateMetadata function was applying .toUpperCase() to the model ID from the URL/page.tsx].
Fix
The .toUpperCase() method call was removed from params.modelId in the generateMetadata function within apps/webapp/app/[modelId]/page.tsx/page.tsx]. This ensures the page title respects the original casing of the model ID.
Testing
Tested locally. Showed no errors