Skip to content

fix(metadata): use original casing for model IDs in page titles#117

Draft
emharsha1812 wants to merge 3 commits intohijohnnylin:mainfrom
emharsha1812:fix-model-id-casing
Draft

fix(metadata): use original casing for model IDs in page titles#117
emharsha1812 wants to merge 3 commits intohijohnnylin:mainfrom
emharsha1812:fix-model-id-casing

Conversation

@emharsha1812
Copy link

This PR resolves Issue #83, which addresses model IDs being incorrectly uppercased.
In apps/webapp/app/[modelId]/page.tsx, the generateMetadata function was applying .toUpperCase() to the model ID from the URL/page.tsx].

Fix

The .toUpperCase() method call was removed from params.modelId in the generateMetadata function within apps/webapp/app/[modelId]/page.tsx/page.tsx]. This ensures the page title respects the original casing of the model ID.

Testing

Tested locally. Showed no errors

@hijohnnylin
Copy link
Owner

thanks! some notes-

  1. I think we uppercase model ID in a few other places as well, which I would like to update:
  • model dropdowns
  • breadcrumbs (? not 100% sure)
  1. the original issue (which i should have written a LOT more detail) was also about accessing the models via URL. for example, https://www.neuronpedia.org/GPT2-SMALL does not work, but https://www.neuronpedia.org/gpt2-small does work. both should actually work since model names should be case insensitive.

  2. also - can you attach screenshots as verification as well? thanks!

@hijohnnylin
Copy link
Owner

addendum to 2) - thsi should also be the case in the API

@hijohnnylin hijohnnylin marked this pull request as draft July 16, 2025 05:56
@hijohnnylin
Copy link
Owner

Moving this to draft until author has time to resolve comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants