Skip to content

replaces print() with logging#114

Merged
hijohnnylin merged 2 commits intoreplace-on_event-with-lifespan-event-handlersfrom
replace-print-with-logging
Aug 18, 2025
Merged

replaces print() with logging#114
hijohnnylin merged 2 commits intoreplace-on_event-with-lifespan-event-handlersfrom
replace-print-with-logging

Conversation

@anthonyduong9
Copy link
Contributor

@anthonyduong9 anthonyduong9 commented Jun 7, 2025

Problem

  • We still use print() where we don't just display console output for a CLI.
  • We configure logging for inference, but not for autointerp.

Fix

  • Removing print() for each autointerp endpoint.
  • Replacing print() in autointerp and inference.
  • Copying and adapting the way we configure logging for inference, to autointerp.

Testing

  • From apps/autointerp, I ran poetry run uvicorn server:app --host 0.0.0.0 --port 5003 --workers 1, made requests to the autointerp endpoints, and verified the logging.
  • From apps/inference, I ran poetry run python start.py, and verified the logging.

@anthonyduong9 anthonyduong9 force-pushed the replace-on_event-with-lifespan-event-handlers branch from 127cc59 to cccbc17 Compare August 14, 2025 23:46
@anthonyduong9 anthonyduong9 force-pushed the replace-print-with-logging branch from 10a1922 to b5e8cf2 Compare August 14, 2025 23:54
@anthonyduong9
Copy link
Contributor Author

Blocked by #87

@anthonyduong9 anthonyduong9 marked this pull request as ready for review August 14, 2025 23:56
@hijohnnylin
Copy link
Owner

thanks. i'll merge since the blocker only contains one mostly optional print statement.

@hijohnnylin hijohnnylin merged commit 9cd85c0 into replace-on_event-with-lifespan-event-handlers Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants