replaces print() with logging#114
Merged
hijohnnylin merged 2 commits intoreplace-on_event-with-lifespan-event-handlersfrom Aug 18, 2025
Merged
replaces print() with logging#114hijohnnylin merged 2 commits intoreplace-on_event-with-lifespan-event-handlersfrom
hijohnnylin merged 2 commits intoreplace-on_event-with-lifespan-event-handlersfrom
Conversation
127cc59 to
cccbc17
Compare
10a1922 to
b5e8cf2
Compare
Contributor
Author
|
Blocked by #87 |
Owner
|
thanks. i'll merge since the blocker only contains one mostly optional print statement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
print()where we don't just display console output for a CLI.inference, but not forautointerp.Fix
print()for eachautointerpendpoint.print()inautointerpandinference.inference, toautointerp.Testing
apps/autointerp, I ranpoetry run uvicorn server:app --host 0.0.0.0 --port 5003 --workers 1, made requests to theautointerpendpoints, and verified the logging.apps/inference, I ranpoetry run python start.py, and verified the logging.