Skip to content

removes unused packages files#112

Open
anthonyduong9 wants to merge 1 commit intomainfrom
remove-unused-packages-files
Open

removes unused packages files#112
anthonyduong9 wants to merge 1 commit intomainfrom
remove-unused-packages-files

Conversation

@anthonyduong9
Copy link
Contributor

@anthonyduong9 anthonyduong9 commented Jun 2, 2025

Problem

  • .gitlab-ci.yml, .travis.yml, .github/ are unused, since CI is in .github/ in the root directory.
  • git_push.sh seems it's meant to be used when the client is in the root directory.
  • test/ contains auto-generated test functions that don't do anything, and get deleted upon generation anyways.
  • tox.ini and test-requirements.txt only matter for test/.
  • setup.cfg only matters for flake8.
  • requirements.txt is redundant with setup.py.
  • .openapi-generator-ignore just has comments, and gets deleted upon generation anyways.

Fix

  • Adding files to skip during OpenAPI Generator code generation, to schemas/.openapi-generator-ignore.
  • Passing schemas/.openapi-generator-ignore to --ignore-file-override in each openapi-generator generate command.
  • Running make setup-all-autointerp VERSION=1.0.0 and make setup-all-inference VERSION=1.3.0.

Testing

I re-ran make setup-all-autointerp VERSION=1.0.0 and make setup-all-inference VERSION=1.3.0.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.86%. Comparing base (e8ddd08) to head (c4b20b4).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #112   +/-   ##
=====================================
  Coverage   7.86%   7.86%           
=====================================
  Files        124     124           
  Lines      17470   17470           
  Branches     381     381           
=====================================
  Hits        1374    1374           
  Misses     16085   16085           
  Partials      11      11           
Flag Coverage Δ
autointerp 100.00% <ø> (ø)
inference 36.78% <ø> (ø)
webapp 5.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anthonyduong9 anthonyduong9 changed the title removes unused schemas files removes unused packages files Jun 2, 2025
@anthonyduong9 anthonyduong9 force-pushed the remove-unused-packages-files branch 2 times, most recently from 6768b54 to c84db68 Compare July 22, 2025 23:30
@anthonyduong9 anthonyduong9 marked this pull request as ready for review July 22, 2025 23:37
@anthonyduong9 anthonyduong9 marked this pull request as draft August 12, 2025 21:57
@anthonyduong9 anthonyduong9 force-pushed the remove-unused-packages-files branch from c84db68 to c4b20b4 Compare August 14, 2025 23:34
@anthonyduong9 anthonyduong9 marked this pull request as ready for review August 14, 2025 23:37
@anthonyduong9
Copy link
Contributor Author

@hijohnnylin if you merge this, I suggest you do it before you merge #84, which increments the minor version.

@hijohnnylin
Copy link
Owner

This is only for the autogenerated clients right? If so I'm fine with having these extra files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants