Patches for _xdb_read_data and xdb_open #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bearlin
commented
Mar 7, 2016
bearlin
commented
- Add some protections in _xdb_read_data
- In xdb_open, add O_BINARY flag for cygwin/windows
libscws/xdb.c
Outdated
|
|
||
| /* try to open & check the file */ | ||
| #ifdef WIN32 | ||
| if ((x->fd = open(fpath, mode == 'w' ? O_RDWR|O_BINARY : O_RDONLY|O_BINARY)) < 0) |
Contributor
Author
There was a problem hiding this comment.
O_BINARY: the 'binary' mode flag on Windows, this flag only exist in Windows platform.
Ref : https://msdn.microsoft.com/en-us/library/tw4k6df8.aspx
Owner
|
I think we can use following code: #ifndef O_BINARY
#define O_BINARY 0
#endif |
Contributor
Author
|
Ok, I will add this and remove the "#ifdef WIN32" around open() |
|
|
||
| #ifndef O_BINARY | ||
| #define O_BINARY 0 | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
Unify the O_BINARY macro for all platforms at the beginning of xdb.c
Contributor
Author
|
@hightman Please review and hope we can merge this PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.