enhancement/env-parsing-with-zod #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulDalek
approved these changes
Apr 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this pull request
We want to make it as easy to debug issues related to improper configuration of the Export Server. Thus, having an environment variable parser go through all the
.envvars set by the user and check if they are properly set, according to our documentation would make the entire product usage smoother (it allows to quickly detect mistakes which could then cause major bugs).Additional note
Zod could also help us with migration to TypeScript, we can easily use it to generate types and we could parse different types of object for an additional safety layer.