Skip to content

Commit

Permalink
Highcharts v11.0.1
Browse files Browse the repository at this point in the history
  • Loading branch information
TorsteinHonsi committed May 8, 2023
1 parent b90bfd6 commit bda2ab9
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 12 deletions.
5 changes: 4 additions & 1 deletion lib/functions.js
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,10 @@ const getNightlyResult = async (date) => {

return JSON.stringify(compare, null, ' ');
} catch (e) {
console.log(`Failed to get visual tests for ${dateString}, continuing...`);
console.log(
`Failed to get visual tests for ${dateString}, continuing...` +
`\n - ${url}`
);
}
}
return `Failed to get results ${daysToTry} days back`;
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"express-session": "^1.17.2",
"glob": "^8.0.1",
"hbs": "^4.2.0",
"highcharts": "^11.0.0",
"highcharts": "^11.0.1",
"hostile": "^1.3.3",
"http-proxy": "^1.18.1",
"husky": "^7.0.4",
Expand Down
5 changes: 5 additions & 0 deletions public/modules/pulls.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const docTitle = document.title;
const ulDrafts = document.getElementById('drafts'),
ulPullsRead = document.getElementById('pulls-read'),
ulPulls = document.getElementById('pulls'),
ulIssues = document.getElementById('issues'),
ulFeatureRequests = document.getElementById('feature-requests');

let lastUpdate = 0;
Expand Down Expand Up @@ -82,6 +83,10 @@ const getUl = pull => {
return ulFeatureRequests;
}

if (!pull.pull_request) {
return ulIssues;
}

return ulPulls;
}

Expand Down
11 changes: 11 additions & 0 deletions routes/pulls.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,16 @@ router.get('/list', async (req, res, next) => {
per_page
}).catch(e => console.error(e));

// Note: this also returns pulls
const issues = await octokit.issues.listForRepo({
...repo,
state: 'open',
sort: 'updated',
direction: 'desc',
per_page: 10
}).catch(e => console.error(e));
issues.data = issues.data.filter(issue => !issue.pull_request);

const featureRequests = await octokit.issues.listForRepo({
...repo,
state: 'open',
Expand All @@ -92,6 +102,7 @@ router.get('/list', async (req, res, next) => {
p.pull_request = true;
return p;
}),
...issues.data,
...featureRequests.data
]
}));
Expand Down
4 changes: 2 additions & 2 deletions routes/samples/compare-report.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const browsers = ['Nightly', 'Chrome', 'Safari', 'Firefox', 'Edge', 'MSIE'];
router.get('/', async (req, res) => {
let compare = {};

const nightlyResult = JSON.parse(await getNightlyResult(Date.now()));
// const nightlyResult = JSON.parse(await getNightlyResult(Date.now()));

browsers.forEach(browser => {
const file = path.join(
Expand All @@ -26,7 +26,7 @@ router.get('/', async (req, res) => {

let results;
if (browser === 'Nightly') {
results = nightlyResult;
// results = nightlyResult;
} else if (fs.existsSync(file)) {
results = require(file);
}
Expand Down
7 changes: 6 additions & 1 deletion views/pulls/main.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
display: flex;
}
.column {
width: 24%;
width: 19%;
padding: 1em;
box-sizing: border-box;
}
Expand Down Expand Up @@ -103,6 +103,11 @@
<ul id="pulls" class="list-group"></ul>
</div>

<div class="column">
<h4 class="mt-1">Issues</h4>
<ul id="issues" class="list-group"></ul>
</div>

<div class="column">
<h4 class="mt-1">Feature requests</h4>
<ul id="feature-requests" class="list-group"></ul>
Expand Down

0 comments on commit bda2ab9

Please sign in to comment.