Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added undocumented Return and RollingReturn Time Series endpoints. #76

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Added undocumented Return and RollingReturn Time Series endpoints. #76

merged 8 commits into from
Feb 19, 2025

Conversation

jedrzejruta
Copy link
Contributor

@jedrzejruta jedrzejruta commented Feb 7, 2025 •
edited
Loading

Added undocumented Return and RollingReturn Time Series endpoints.

TODO:

  • - Fix invalid Dividend series response parsing - NaN's returned instead of real values.
  • - Investigate if the RollingReturn window can be changed with request params (default = 10 days).

@jedrzejruta jedrzejruta added the enhancement New feature or request label Feb 7, 2025
@jedrzejruta jedrzejruta self-assigned this Feb 7, 2025
@jedrzejruta jedrzejruta marked this pull request as ready for review February 11, 2025 19:17
DJTechnoo
DJTechnoo approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@DJTechnoo DJTechnoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kamil-musialowski
kamil-musialowski requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@kamil-musialowski kamil-musialowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good imo! Just one minor change in tests to discuss.

pawelfus
pawelfus requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Can we add a demo presenting both on the same chart? I mean RollingReturn vs Return.

@jedrzejruta jedrzejruta requested a review from pawelfus February 18, 2025 15:19
@jedrzejruta jedrzejruta changed the title feature/missing-timeseries-connectors Added undocumented Return and RollingReturn Time Series endpoints. Feb 18, 2025
@jedrzejruta jedrzejruta changed the title Added undocumented Return and RollingReturn Time Series endpoints. Added undocumented Return and RollingReturn Time Series endpoints. Feb 18, 2025
pawelfus
pawelfus approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawelfus pawelfus merged commit e47138e into main Feb 19, 2025
5 checks passed
@pawelfus pawelfus deleted the feature/missing-timeseries-connectors branch February 19, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelfus pawelfus pawelfus approved these changes

@DJTechnoo DJTechnoo DJTechnoo approved these changes

@kamil-musialowski kamil-musialowski kamil-musialowski approved these changes

Assignees

@jedrzejruta jedrzejruta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jedrzejruta @pawelfus @DJTechnoo @kamil-musialowski