feat: add runtime device capability inventory#1
Open
hieshima wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Stacked on TomBadash#143.
TomBadash#141 adds broader MX Master / MX Anywhere visual catalog support, and TomBadash#143 gates static catalog buttons against discovered HID++ controls. This PR turns that guardrail into a first-class runtime capability inventory so future device support can be added from real HID++ evidence instead of only static model/catalog assumptions.
This is motivated by current device-support issues with useful runtime dumps:
0x00D0, not the usual virtual gesture CID.0x00ED, which Mouser can see but does not yet support as a remappable button.0xC52B, so it must be resolved conservatively by HID++ product name rather than receiver PID.0x01A0, which should be recorded as known-but-not-exposed until Mouser implements that button type.What changed
DeviceCapabilityInventory, derived from runtime HID++ data:REPROG_CONTROLS_V4controlssupported_buttonsas the UI-facing result, but now derives it from the inventory.derive_supported_buttons_from_reprog_controls()as a compatibility wrapper for fix: gate wider mouse catalog buttons by HID capabilities TomBadash/Mouser#143.capability_inventorytoCopy device infodumps so future issues/PRs show Mouser’s capability decisions directly.0x01A0as MX Master 4 haptic/action-ring0x00EDas MX Ergo precision modeCONTRIBUTING_DEVICES.mdto require runtime capability evidence for future device support PRs.Scope
This does not add full support for M720 / MX Ergo / M575 yet.
The new device entries are conservative: they improve recognition and runtime capability filtering without pretending every physical control is fully supported.
It intentionally does not add:
Compatibility
derive_supported_buttons_from_reprog_controls().supported_buttons; they do not need to know about the new inventory.flagskeep the previous CID-only behavior.Tests