Fixed: Prefer newer rsa versions (256 and 512) before legacy (ssh-rsa) #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), when the host it's added to known_hosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the host is added to known_hosts and it supports rsa-sha2-256 or rsa-sha2-512, the filterKnownHostKeyAlgorithms method put first ssh-rsa before the newer versions. That's because the signature is ssh-rsa in the known_hosts file. if the server only accepts as its first or only method rsa-sha2-512, the connection will fail since the preferred method on the client side is still the outdated ssh-rsa.