feat: update k8 secret whenever admin key changed/updated/deleted #3062
+61
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
|
✨ Submitted to Merge by @JeffreyDallas. It will be added to the merge queue once all branch protection rules pass and there are no merge conflicts with the target branch. See more details here. |
Contributor
Contributor
Contributor
Contributor
E2E Test Report 9 files 88 suites 1h 43m 38s ⏱️ Results for commit 6da9188. ♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
JeffreyDallas
added
the
PR: Needs Team Approval
instamenta
previously approved these changes
Dec 11, 2025
Signed-off-by: Jeffrey Tang <[email protected]>
jeromy-cannon
added
PR: Unresolved Comments
…dmin-key-persistence
Signed-off-by: Jeffrey Tang <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
JeffreyDallas
added
the
PR: Needs Team Approval
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
instamenta
previously approved these changes
Dec 23, 2025
Contributor
Log Metrics - Performance TestJSON Log Metrics |
src/commands/node/tasks.ts
Outdated
| await this.k8Factory | ||
| .getK8(context) | ||
| .secrets() | ||
| .create(config.namespace, Templates.renderNodeAdminKeyName(nodeAlias), SecretType.OPAQUE, data, { |
Contributor
There was a problem hiding this comment.
I think if you use createOrReplace here it will be better so, that if the user already ran the command and wants to run it again, it will be more idempotent
jeromy-cannon
added
PR: Checks Failed
Signed-off-by: Jeffrey Tang <[email protected]>
Contributor
Log Metrics - One Shot Single - using Podman📊 Runner Resource UsageJSON Log Metrics |
Contributor
Log Metrics - One Shot Single📊 Runner Resource UsageJSON Log Metrics |
Contributor
Log Metrics - External database new📊 Runner Resource UsageJSON Log Metrics |
Contributor
Log Metrics - Integration📊 Runner Resource UsageJSON Log Metrics |
Contributor
Log Metrics - Block Node📊 Runner Resource Usage |
Contributor
Log Metrics - Node Upgrade📊 Runner Resource Usage |
Contributor
Log Metrics - Node Local PTT📊 Runner Resource Usage |
Contributor
Log Metrics - Dual Cluster Full📊 Runner Resource UsageJSON Log Metrics |
Contributor
Log Metrics - Node Add Local📊 Runner Resource Usage |
Contributor
Log Metrics - Standard📊 Runner Resource UsageJSON Log Metrics |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues
gcs-storage-testare failing more frequently in CI in create topic part of smoke test #2813Pull request (PR) checklist
package.jsonchanges have been explained to and approved by a repository managerTesting
The following manual testing was done:
The following was not tested:
Commit message guidelines
We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages: