HHH-19872: CriteriaUpdate for generic fields #11130
Merged
+173
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbellade
reviewed
Oct 17, 2025
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/TypecheckUtil.java
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/TypecheckUtil.java
Outdated
Show resolved
Hide resolved
...ate-core/src/test/java/org/hibernate/orm/test/annotations/generics/GenericHierarchyTest.java
Outdated
Show resolved
Hide resolved
...a/org/hibernate/orm/test/annotations/generics/GenericMappedSuperclassPropertyUpdateTest.java
Show resolved
Hide resolved
|
Thanks for the review, changes were made according to your recommandations. |
mbellade
reviewed
Oct 17, 2025
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/TypecheckUtil.java
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/TypecheckUtil.java
Outdated
Show resolved
Hide resolved
|
It should be OK now 🤞. Thank's ! |
tcordel
force-pushed
the
HHH-19872
branch
2 times, most recently
from
50cda3b to
78fe917
Compare
mbellade
reviewed
Oct 20, 2025
...ate-core/src/test/java/org/hibernate/orm/test/annotations/generics/GenericHierarchyTest.java
Outdated
Show resolved
Hide resolved
|
Generated model gen has not been refactor in test, i'll send a new patch |
|
Seems to be ok now |
|
Is there anything i can do for this pipeline error ? |
|
That's fine don't worry, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19872