HHH-19846 - Drop JUnit 4 usage #11102
Draft
+15,851
−18,361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| public Set getEnrollments() { | ||
| public Set<Enrollment> getEnrollments() { |
Check notice
Code scanning / CodeQL
Exposing internal representation Note test
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/manytoone/ManyToOneTest.java
Fixed
Show fixed
Hide fixed
...e-core/src/test/java/org/hibernate/orm/test/fetchstrategyhelper/FetchStrategyHelperTest.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/test/java/org/hibernate/orm/test/hql/BulkManipulationTest.java
Dismissed
Show dismissed
Hide dismissed
hibernate-core/src/test/java/org/hibernate/orm/test/ternary/Employee.java
Dismissed
Show dismissed
Hide dismissed
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
Cannot convert... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization
sebersole
force-pushed
the
drop-junit4
branch
from
e204062 to
3ab1246
Compare
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
| @Override | ||
| public StandardServiceRegistry produceServiceRegistry(StandardServiceRegistryBuilder builder) { | ||
| try { | ||
| var dropOutput = File.createTempFile( "drop_script", ".sql" ); |
Check warning
Code scanning / CodeQL
Local information disclosure in a temporary directory Medium test
| public StandardServiceRegistry produceServiceRegistry(StandardServiceRegistryBuilder builder) { | ||
| try { | ||
| var dropOutput = File.createTempFile( "drop_script", ".sql" ); | ||
| var createOutput = File.createTempFile( "create_script", ".sql" ); |
Check warning
Code scanning / CodeQL
Local information disclosure in a temporary directory Medium test
| public void testBooleanType() { | ||
| final Boolean original = Boolean.TRUE; | ||
| //noinspection UnnecessaryBoxing,removal,BooleanConstructorCall |
Check notice
Code scanning / CodeQL
Inefficient primitive constructor Note test
hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/ServiceRegistryProducer.java
Fixed
Show fixed
Hide fixed
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
| public class BackrefPropertyRefTest extends BackrefTest { | ||
| @Test | ||
| void verifyMapping(DomainModelScope modelScope, SessionFactoryScope factoryScope) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
| private MetadataImplementor metadata; | ||
| private final List<AutoCloseable> toClose = new ArrayList<>(); | ||
| private SessionFactoryImplementor sessionFactory; | ||
| private SessionFactoryScope factoryScope; |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
| private final List<AutoCloseable> toClose = new ArrayList<>(); | ||
| private SessionFactoryImplementor sessionFactory; | ||
| private SessionFactoryScope factoryScope; | ||
|
|
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
| private SessionFactoryImplementor sessionFactory; | ||
| private SessionFactoryScope factoryScope; | ||
|
|
||
| private final List<AutoCloseable> autoCloseables = new ArrayList<>(); |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
| private SessionFactoryScope factoryScope; | ||
|
|
||
| private final List<AutoCloseable> autoCloseables = new ArrayList<>(); | ||
|
|
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
|
|
||
| private final List<AutoCloseable> autoCloseables = new ArrayList<>(); | ||
|
|
||
| public DefaultCatalogAndSchemaTest(Options options) { |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
| private final List<AutoCloseable> autoCloseables = new ArrayList<>(); | ||
|
|
||
| public DefaultCatalogAndSchemaTest(Options options) { | ||
| this.options = options; |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
| metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-catalog-placeholder.orm.xml" ) ); | ||
| metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-schema-placeholder.orm.xml" ) ); | ||
| if ( options.xmlMapping != null ) { | ||
| metadataSources.addInputStream( getClass().getResourceAsStream( options.xmlMapping ) ); |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
| ) | ||
| @DomainModel(annotatedClasses = TheEntity.class) | ||
| @SessionFactory | ||
| public void testIt(CdiContainerScope containerScope, SessionFactoryScope factoryScope) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
| )) | ||
| @DomainModel(annotatedClasses = TheEntity.class) | ||
| @SessionFactory | ||
| public void testAnnotations(CdiContainerScope containerScope, SessionFactoryScope factoryScope) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
| )) | ||
| @DomainModel(annotatedClasses = TheEntity.class, xmlMappings = "org/hibernate/test/cdi/converters/orm.xml") | ||
| @SessionFactory | ||
| public void testOrmXml(CdiContainerScope cdiScope, SessionFactoryScope factoryScope) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
| } | ||
|
|
||
| interface SettingResolver { | ||
| Object resolve(StandardServiceRegistryBuilder registryBuilder, ExtensionContext junitContext); |
Check notice
Code scanning / CodeQL
Useless parameter Note test
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
Comment on lines
+92
to
+113
| long count = session.doReturningWork( (connection) -> { | ||
| // in this current form, users must handle try/catches themselves for proper resource release | ||
| Statement statement = null; | ||
| long personCount = 0; | ||
| try { | ||
| statement = session.getJdbcCoordinator().getStatementPreparer().createStatement(); | ||
| ResultSet resultSet = null; | ||
| try { | ||
| resultSet = session.getJdbcCoordinator().getResultSetReturn().extract( statement, "select count(*) from T_JDBC_PERSON" ); | ||
| resultSet.next(); | ||
| personCount = resultSet.getLong( 1 ); | ||
| assertEquals( 1L, personCount ); | ||
| } | ||
| finally { | ||
| releaseQuietly( session, resultSet, statement ); | ||
| } | ||
| } | ||
| ); | ||
| session2.getTransaction().commit(); | ||
| session2.close(); | ||
| assertEquals( 1L, count ); | ||
|
|
||
| session = openSession(); | ||
| session.beginTransaction(); | ||
| session.remove( p ); | ||
| session.getTransaction().commit(); | ||
| session.close(); | ||
| finally { | ||
| releaseQuietly( session, statement ); | ||
| } | ||
| return personCount; | ||
| } ); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
| finally { | ||
| session.close(); | ||
| factoryScope.inTransaction( session, (s) -> session.doWork( connection -> { | ||
| final Statement stmnt = connection.createStatement(); |
Check warning
Code scanning / CodeQL
Potential database resource leak Warning test
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
| persistenceContext.getCollectionsByKey().values().contains( publisher.getAuthors() ) ); | ||
| Assertions.assertEquals( 0, actionQueue.numberOfCollectionRemovals() ); | ||
|
|
||
| Set<Author> authorsOld = publisher.getAuthors(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
Comment on lines
160
to
+167
| List<Object> objects = session.createQuery( | ||
| "from java.lang.Object", | ||
| Object.class) | ||
| .getResultList(); | ||
| "from java.lang.Object", | ||
| Object.class) | ||
| .getResultList(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Comment on lines
166
to
+172
| List<Person> persons = session.createQuery( | ||
| "from Person", Person.class) | ||
| .getResultList(); | ||
| "from Person", Person.class) | ||
| .getResultList(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Comment on lines
172
to
+179
| LocalDateTime datetime = session.createQuery( | ||
| "select local datetime", | ||
| LocalDateTime.class) | ||
| .getSingleResult(); | ||
| "select local datetime", | ||
| LocalDateTime.class) | ||
| .getSingleResult(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
| public void test_jpql_api_named_query_example() { | ||
| doInJPA(this::entityManagerFactory, entityManager -> { | ||
| public void test_jpql_api_named_query_example(SessionFactoryScope factoryScope) { | ||
| factoryScope.inTransaction( entityManager -> { |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Comment on lines
1108
to
+959
| List<Person> persons = personStream | ||
| .skip(5) | ||
| .limit(5) | ||
| .collect(Collectors.toList()); | ||
| .toList(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
| public void test_hql_api_positional_parameter_example() { | ||
| doInJPA(this::entityManagerFactory, entityManager -> { | ||
| @Test | ||
| @ExpectedException( IllegalArgumentException.class ) |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Check notice
Code scanning / CodeQL
Unread local variable Note test
Not converted... * org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function * org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object * org.hibernate.orm.test.id.usertype - type registrations * org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests * org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest) * org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping usage of JUnit 4
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19846