fix(viteroll): handle any script src

hi-ogawa · Nov 9, 2024 · 2a2b4ae · 2a2b4ae
1 parent f950271
commit 2a2b4ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/viteroll/index.html b/viteroll/index.html
@@ -6,6 +6,6 @@
   </head>
   <body>
     <div id="root"></div>
-    <script src="./src/index.ts"></script>
+    <script type="module" src="./src/index.ts"></script>
   </body>
 </html>
diff --git a/viteroll/viteroll.ts b/viteroll/viteroll.ts
@@ -276,7 +276,9 @@ function viterollEntryPlugin(
 				}
 
 				// extract <script src="...">
-				const matches = code.matchAll(/<script\s+src="([^"]+)"><\/script>/dg);
+				const matches = code.matchAll(
+					/<script\b[^>]+\bsrc=["']([^"']+)["'][^>]*>.*?<\/script>/dg,
+				);
 				for (const match of matches) {
 					const src = match[1];
 					const resolved = await this.resolve(src, id);