1.13 #89
1.13 #89
Conversation
|
|
|
Yo @givanse you're the fucking MAN Comments coming shortly |
| var SpreeService = container.lookup('service:spree'); | ||
| CurrentOrderSupport.apply(SpreeService); | ||
|
|
||
| application.deferReadiness(); | ||
| SpreeService._restoreCurrentOrder().finally(function() { | ||
| //TODO:https://github.com/emberjs/ember.js/issues/11247 | ||
| application.advanceReadiness(); |
There was a problem hiding this comment.
I have a work around for this coming soon
|
Only Is the upgrade to ember-simple-auth 0.8.0 done? or half way there? Just noticed the version number in |
|
I'll have a look at Auth! Just haven't got around to bumping the version of simple auth yet - it was in beta when 0.0.1 was released |
|
@givanse - I should have time to work on this this week - can I have push for your fork? I'll do all my work on this branch |
|
@hhff Yes, added you. |
|
thanks @givanse ! |
|
@hhff Did you update the backend that is used when the tests are run? (http://testing.spree-ember.com) |
|
@givanse - I haven't - it's been the same for a while. Does it need a change? |
|
Some tests that were ok before are failing now. Simple things like: Maybe a sorting change in the taxons? I fixed (edited for Mugs) and four more errors appeared. Maybe the seed data was edited? I didn't spend much time looking into this, decided to wait for a reply. If nothing has changed, I'll check what is going on. |
|
yeah i haven't changed it at all - but I'm guessing it's just an ordering thing - so if the tests explicitly "clicked" the mugs label rather than the first item, we should be cool |
|
thank you so so much for working on this @givanse u are the mannnnn |
I'm still working on changes for the other addons, but I figured that it would be good to start pushing as I have them ready so I can have early feedback.
This PR upgrades the addons to
ember-cli 1.13.1, but keepsember 0.12.0andember-data 1.0.0-beta.18. The changes pave the way towards 2.0.core
storefront
auth
checkouts