#168 Service worker #680
#168 Service worker #680
Conversation
M4ttoF
force-pushed
the
168
branch
2 times, most recently
from
f7295f7 to
13d658c
Compare
…even when offline
|
|
||
| var cacheFiles = []; | ||
|
|
||
| self.addEventListener('install', function(e) { |
There was a problem hiding this comment.
Where is "self" defined?
| @@ -0,0 +1,6 @@ | |||
| importScripts('https://www.gstatic.com/firebasejs/4.8.1/firebase-app.js'); | |||
There was a problem hiding this comment.
I'm not sure where this is coming from but there are some JavaScript errors when visiting the home page of the site. The errors lead to the Google Map not working.
I did not install firebase on app.accesslocator.com. Would that be the cause?
Here's a screenshot of them:
I'm going to undeploy the changes now since you ran the audit and made a screenshot.
| <script> | ||
| // Initialize Firebase | ||
| var config = { | ||
| apiKey: "AIzaSyBX6l4geba-CjXE_WlQwOX6pxCIrVl-tjk", |
There was a problem hiding this comment.
I know you're still working on this but after you get everything working to your satisfaction, API keys like this one should be moved to .env and be taken from there like we do with the Google Maps API key.
…nment variables to hide api key
|
Can you make it so the service worker is active only when the application is run as a PWA? The start_url in the manifest.json is "/?using_pwa=1". Maybe that can help you differentiate between when it is run as a progressive web application and not. |
|
@joshi1983 Updated the PR |
|
I'm closing this because it has some caching problems and pull request #688 is taking over what this was intended to do. |
Included some stuff for firebase which will be used for the push notifications later. It is not completely setup but the service worker still saves caches properly and has no issues.