Contribution Guide

heyglen · Dec 7, 2017 · 50846f0 · 50846f0
1 parent 321a155
commit 50846f0
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 2 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -0,0 +1,24 @@
+# Contributing
+
+When contributing to this repository, please first discuss the change you wish to make via an issue with the owners of the repository before making a change.
+
+Changes should be submitted using the pull request process.
+
+## Change Log
+
+Changes, features, and bug fixes are documented in a changelog files located in messages/<version>.md
+
+New changelogs should be referenced in the messages.json file
+
+Changelogs follow the [Keep a Changelog Standard](http://keepachangelog.com)
+
+## Testing
+
+### Syntax
+
+- New syntax should be written in the relevant test files:
+    - [ios: tests/syntax_test_cisco_ios.cisco-ios](tests/syntax_test_cisco_ios.cisco-ios)
+    - [nxos: tests/syntax_test_cisco_nxos.cisco-nxos](tests/syntax_test_cisco_nxos.cisco-nxos)
+    - [asa: tests/syntax_test_cisco_asa.cisco-asa](tests/syntax_test_cisco_asa.cisco-asa)
+    - [ace: tests/syntax_test_cisco_ace.cisco-ace](tests/syntax_test_cisco_ace.cisco-ace)
+- These files are used for testing the syntax by visual inspection
diff --git a/messages.json b/messages.json
@@ -10,4 +10,5 @@
     "2.9.0": "messages/2.9.0.md",
     "2.10.0": "messages/2.10.0.md",
     "2.10.1": "messages/2.10.1.md",
+    "2.11.0": "messages/2.11.0.md",
 }
diff --git a/messages/2.10.1.md b/messages/2.10.1.md
@@ -1,4 +1,4 @@
-# [2.11.1] - 2017-11-28
+# [2.10.1] - 2017-11-28
 
 ## Bugfixes
 

diff --git a/messages/2.11.0.md b/messages/2.11.0.md
@@ -0,0 +1,17 @@
+# [2.11.0] - 2017-12-07
+
+## Added
+
+- Syntax detection
+
+    - Cisco ASA
+
+        - route statements
+
+- Contributing guidelines
+
+## Fixed
+
+- License stuff - thank you @eckelcu
+
+- The networking info popup will now only show the first result when muliple cursors hover over multiple networks
diff --git a/network_tech.py b/network_tech.py
@@ -45,9 +45,10 @@
         '^\s*security-level \d+$',
         '^\s*nameif \S+$',
         '^\s*access-list cached ACL log flows:',
+        '^\s*route\s+\S+\d+',
         '^\s*fragment chain \d+ \S+$',
         '^\s*asdm image \S+$',
-        '^\s*same-security-traffic permit',
+        '^\s*same-security-traffic',
     ],
     'nxos': [
         '^!Command: show ',
@@ -252,6 +253,8 @@ def network_info(self, point=None, location=None):
                             flags=sublime.COOPERATE_WITH_AUTO_COMPLETE,
                             location=location,
                         )
+            # Match only the first
+            break
 
 
 class AutoSyntaxDetection(sublime_plugin.ViewEventListener):

diff --git a/tests/syntax_test_cisco_asa.cisco-asa b/tests/syntax_test_cisco_asa.cisco-asa
@@ -316,6 +316,7 @@ service-policy global_policy global
 
 logout
 
+! TODO
 same-security-traffic permit inter-interface
 same-security-traffic permit intra-interface
-Original file line number
+Diff line change
@@ Expand Up / @@ -316,6 +316,7 @@ service-policy global_policy global @@
     logout
+    ! TODO
     same-security-traffic permit inter-interface
     same-security-traffic permit intra-interface